diff --git a/src/addrman_impl.h b/src/addrman_impl.h index fcc1d8d7786f1a..a3246da0eeb95d 100644 --- a/src/addrman_impl.h +++ b/src/addrman_impl.h @@ -32,8 +32,12 @@ static constexpr int ADDRMAN_NEW_BUCKET_COUNT{1 << ADDRMAN_NEW_BUCKET_COUNT_LOG2 static constexpr int32_t ADDRMAN_BUCKET_SIZE_LOG2{6}; static constexpr int ADDRMAN_BUCKET_SIZE{1 << ADDRMAN_BUCKET_SIZE_LOG2}; -/** User-defined type for the internally used nIds */ -using nid_type = int; +/** + * User-defined type for the internally used nIds + * This used to be int, making it feasible for attackers to cause an overflow, + * see https://bitcoincore.org/en/2024/07/31/disclose-addrman-int-overflow/ + */ +using nid_type = int64_t; /** * Extended statistics about a CAddress