Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #89

Open
teddybee opened this issue Jan 11, 2022 · 6 comments
Open

Typescript support #89

teddybee opened this issue Jan 11, 2022 · 6 comments

Comments

@teddybee
Copy link

It would be great to have type definition package for this lib.

@farminf
Copy link
Owner

farminf commented Feb 22, 2022

I try my best but I can't promise... I'll be active after couple of years on this repo and try to upgrade some packages and also move to functional react and hooks

@kayvaninvemo
Copy link

for the moment I used the augmentation as this

declare module "pannellum-react" {
  function Pannellum(props: any): JSX.Element;
}


@kayvaninvemo
Copy link

kayvaninvemo commented Apr 9, 2022

I also created a repo to support TypeScript, I can create PR if you like it

@farminf
Copy link
Owner

farminf commented Apr 18, 2022

yes sir, please :)

@kayvaninvemo
Copy link

Here I created the PR

@arcticfly
Copy link

@farminf How would you feel about releasing a new npm version with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants