Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added link to artist page #7

Closed
siggi1984 opened this issue Sep 30, 2023 · 15 comments
Closed

added link to artist page #7

siggi1984 opened this issue Sep 30, 2023 · 15 comments
Labels
bug Something isn't working enhancement New feature or request implemented Feature or request have been developed

Comments

@siggi1984
Copy link

Description

Clicking on the artist's name in the song player below the title should take you to the artist's page. Without the current detours.

Would such a function be possible.

Suggested Solution

Uploading Screenshot_20231001-004337.jpg…

Alternatives

No response

Additional Context

No response

@fast4x
Copy link
Owner

fast4x commented Oct 3, 2023

Uploaded screenshot is damaged, can you re upload, please?

@siggi1984
Copy link
Author

Screenshot_20231003-095835

@fast4x
Copy link
Owner

fast4x commented Oct 3, 2023

Thanks

@fast4x
Copy link
Owner

fast4x commented Oct 3, 2023

Feature implemented, available in next release.

@fast4x fast4x closed this as completed Oct 4, 2023
@fast4x fast4x added the implemented Feature or request have been developed label Oct 4, 2023
@siggi1984
Copy link
Author

Does not work, can click on the artist name as much as I want nothing happens

@fast4x
Copy link
Owner

fast4x commented Oct 4, 2023

have you tried clicking on different points of the artist's name, in different songs? Android version?

@siggi1984
Copy link
Author

have you tried clicking on different points of the artist's name, in different songs? Android version?

I have tried umpteen songs and clicked around at various points without a reaction.

Android 12

@fast4x
Copy link
Owner

fast4x commented Oct 4, 2023

Ok, your device type?
I try to understand problem.

@siggi1984
Copy link
Author

Ok, your device type? I try to understand problem.

Samsung Galaxy a21s

@fast4x fast4x reopened this Oct 4, 2023
@fast4x fast4x added the bug Something isn't working label Oct 4, 2023
@dainvincible1
Copy link

for me it works when there is a single artist but if there are more than one artist then no reaction is there

video_2023-10-05_11-46-00.mp4

@fast4x
Copy link
Owner

fast4x commented Oct 5, 2023

Yes, I confirm that with more than one artist there is no reaction because he can not open more than one artist page at the same time.
It would be nice to be able to choose which one to open.

There is another condition in which there is no reaction, when the song does not have the artist code, there is no reaction, there can not be because the artist has only the name and not the code that serves to identify it.

These are unofficial songs, not by the original artist, copies.

@fast4x
Copy link
Owner

fast4x commented Oct 5, 2023

I change the coloring of the artist name if the song does not have the artist code.
I try to handle the case with more than one artist, choosing which one to open.

@fast4x
Copy link
Owner

fast4x commented Oct 7, 2023

I found the bug that disables the click to the artist page.

@fast4x
Copy link
Owner

fast4x commented Oct 8, 2023

@dainvincible1 @siggi1984 There were some conditions where artist information was not handled
Fixed on v0.6.3 published now

@fast4x fast4x closed this as completed Oct 8, 2023
@siggi1984
Copy link
Author

Works now. Thank you for your work.
Well done 👍

@fast4x fast4x added the enhancement New feature or request label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request implemented Feature or request have been developed
Projects
None yet
Development

No branches or pull requests

3 participants