-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update the Progress Bar tutorial with correct output #199
Conversation
make it more obvious to understand what this is doing
Match the console output to the code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #199 +/- ##
===========================================
+ Coverage 96.24% 100.00% +3.75%
===========================================
Files 280 242 -38
Lines 5942 4508 -1434
===========================================
- Hits 5719 4508 -1211
+ Misses 223 0 -223 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
I updated the PR to be in-sync with the latest from master
and this now looks good to merge to me.
Apologies for the long delay in reviewing this!
📝 Docs preview for commit 6f75088 at: https://fe336598.typertiangolo.pages.dev |
📝 Docs preview for commit 02fee7b at: https://a3c66b6a.typertiangolo.pages.dev Modified Pages |
Great, thank you, and thanks for the patience! 🍰 Thank you @svlandeg 🙇 |
Fix inconcsistency between code and quoted output and add a comment to make it more obvious what the progress.update(..) method does.