-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Remove Rich tags when showing completion text #877
Conversation
PR Review according to #821. zsh on Linux
|
It seems it was something that changed with converting Rich output to HTML: #1055 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! 🙇 🚀
Upon completion, print the help text with Rich if it's available. Fixes #822.
Original behaviour, as reported in #822: hitting TAB TAB shows the autocompletion with literal Rich formatting, e.g.
With this PR, the Rich tags are removed:
In my experiments, this does not yet actually format the text with the right colors etc. Not sure whether that's due to the shells/OS's I've tried - further input from others using different systems would be appreciated!
Powershell on Windows
master
GitBash using
zsh
shell on WindowsI couldn't yet get this shell to work with Rich formatting - probably because it's an emulated shell.
master