🐛 Fix equality check for custom classes #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
changed the title
svlandeg
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Thanks for the PR!
Changing the check from equality to identity check seems correct to me, also considering that the official Python documentation on inspect.Parameter also includes this snippet:
if param.default is param.empty
The test you included fails on master and succeeds on this PR. I only added 2 more lines to ensure 100% code coverage.
svlandeg
reviewed
Sep 9, 2024
tests/test_annotated.py
Outdated
| @@ -76,3 +76,35 @@ def cmd(force: Annotated[bool, typer.Option("--force")] = False): | |||
| result = runner.invoke(app, ["--force"]) | |||
| assert result.exit_code == 0, result.output | |||
| assert "Forcing operation" in result.output | |||
|
|
|||
|
|
|||
| def test_default_with_class_with_custom_eq(): | |||
There was a problem hiding this comment.
Tiangolo: we might want this test in a different location in the test suite?
There was a problem hiding this comment.
Good point! I just moved it to another file. Not sure about the name, but it will work for now. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to This issue in
rich, comparing types with==could be problematic. The canonicaliswould fix this problem.