-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace archy with a specific implementation, refactor timetree #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
it might be worth moving that archy clone in another repo, I think we use it in find-my-way as well |
I have a fork - https://github.com/Eomm/node-archy |
I removed unreachable code, added jsdoc typings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
archy is 9 years old and you can not find the repo on github anymore.
this PR replaces the need for archy and removes some double processing
added also a unit test as #205 got also fixed, i presume.
Edit:
removed unreachable code and added jsdoc types.
test coverage 100% for time-tree.js
Checklist
npm run test
andnpm run benchmark
and the Code of conduct