From b6ff5c2b8bcb1133fdf9d2515378a0404e01a04e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 28 Aug 2023 22:56:01 +0000 Subject: [PATCH 1/4] build(deps-dev): bump @typescript-eslint/eslint-plugin Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.62.0 to 6.5.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.5.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1c28181..6f657fb 100644 --- a/package.json +++ b/package.json @@ -31,7 +31,7 @@ "homepage": "https://github.com/fastify/fastify-type-provider-typebox#readme", "devDependencies": { "@types/node": "^20.1.0", - "@typescript-eslint/eslint-plugin": "^5.32.0", + "@typescript-eslint/eslint-plugin": "^6.5.0", "@typescript-eslint/parser": "^5.32.0", "eslint": "^8.21.0", "eslint-config-standard": "^17.0.0", From 478fe7c8233c59b45503ae37ebd7aec9c6f97a4a Mon Sep 17 00:00:00 2001 From: Uzlopak Date: Tue, 29 Aug 2023 00:56:41 +0200 Subject: [PATCH 2/4] fix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 6f657fb..a1b874a 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "devDependencies": { "@types/node": "^20.1.0", "@typescript-eslint/eslint-plugin": "^6.5.0", - "@typescript-eslint/parser": "^5.32.0", + "@typescript-eslint/parser": "^6.5.0", "eslint": "^8.21.0", "eslint-config-standard": "^17.0.0", "eslint-plugin-import": "^2.26.0", From f794466a3b721179d6519a542df1056a1ca35b84 Mon Sep 17 00:00:00 2001 From: Uzlopak Date: Wed, 6 Sep 2023 14:19:41 +0200 Subject: [PATCH 3/4] run linting in node 20 --- .github/workflows/ci.yml | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f815d49..7f4f652 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,31 @@ jobs: - name: Dependency review uses: actions/dependency-review-action@v3 + lint: + name: Lint + runs-on: 'ubuntu-latest' + permissions: + contents: read + steps: + - name: Check out repo + uses: actions/checkout@v3 + with: + persist-credentials: false + + - name: Setup Node 20 + uses: actions/setup-node@v3 + with: + node-version: 20 + + - name: Install dependencies + run: npm i --ignore-scripts + + - name: Install peerdeps + run: npm i fastify @sinclair/typebox@${{ matrix.peer-version }} + + - name: Lint code + run: npm run lint + variants: name: Read test variants runs-on: ubuntu-latest @@ -84,9 +109,6 @@ jobs: - name: Install peerdeps run: npm i fastify @sinclair/typebox@${{ matrix.peer-version }} - - name: Lint code - run: npm run lint - - name: Run tests run: npm test From e448a0310d8cab0c764a6e175557fb248eaf48c5 Mon Sep 17 00:00:00 2001 From: Uzlopak Date: Wed, 6 Sep 2023 14:20:24 +0200 Subject: [PATCH 4/4] make variants depending on lint --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7f4f652..c89534f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -63,6 +63,7 @@ jobs: variants: name: Read test variants + needs: lint runs-on: ubuntu-latest permissions: contents: read