From df77472e8d35fec6f7f55df39277ef331cf2045e Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Wed, 12 Jan 2022 08:06:12 +0000 Subject: [PATCH] chore!: remove coveralls jobs from workflows (#7) --- .github/workflows/plugins-ci-mysql.yml | 38 ----------------------- .github/workflows/plugins-ci-postgres.yml | 38 ----------------------- .github/workflows/plugins-ci.yml | 38 ----------------------- README.md | 10 +----- 4 files changed, 1 insertion(+), 123 deletions(-) diff --git a/.github/workflows/plugins-ci-mysql.yml b/.github/workflows/plugins-ci-mysql.yml index dde4c05..e8cc9c5 100644 --- a/.github/workflows/plugins-ci-mysql.yml +++ b/.github/workflows/plugins-ci-mysql.yml @@ -2,20 +2,11 @@ name: Plugin CI - MySQL on: workflow_call: - inputs: - generate-coverage: - description: 'Set to true to generate coverage and send to Coveralls.' - required: false - type: boolean jobs: test: runs-on: ${{ matrix.os }} - # output.COVERALLS is a variable to determine whether we should post to coveralls when all parallel test finish - outputs: - COVERALLS: ${{ steps.coveralls-trigger.outputs.COVERALLS_TRIGGER }} - strategy: matrix: node-version: [10, 12, 14, 16] @@ -49,35 +40,6 @@ jobs: - name: Run Tests run: npm test - - name: Coveralls Parallel - id: coveralls-parallel - if: inputs.generate-coverage == true - continue-on-error: true - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.github_token }} - parallel: true - flag-name: run-${{ matrix.node-version }}-${{ matrix.os }} - - - name: Should Trigger coverallsapp/github-action - id: coveralls-trigger - # https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context - # when continue-on-error failed, outcome is failure and conclusion is success - if: inputs.generate-coverage == true && steps.coveralls-parallel.conclusion == 'success' && steps.coveralls-parallel.outcome != 'success' - run: | - echo "::set-output name=COVERALLS_TRIGGER::failure" - - coverage: - needs: test - runs-on: ubuntu-latest - if: inputs.generate-coverage == true && needs.test.outputs.COVERALLS != 'failure' - steps: - - name: Coveralls Finished - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - parallel-finished: true - automerge: needs: test permissions: diff --git a/.github/workflows/plugins-ci-postgres.yml b/.github/workflows/plugins-ci-postgres.yml index 53efb53..d673d42 100644 --- a/.github/workflows/plugins-ci-postgres.yml +++ b/.github/workflows/plugins-ci-postgres.yml @@ -2,20 +2,11 @@ name: Plugin CI - PostgreSQL on: workflow_call: - inputs: - generate-coverage: - description: 'Set to true to generate coverage and send to Coveralls.' - required: false - type: boolean jobs: test: runs-on: ${{ matrix.os }} - # output.COVERALLS is a variable to determine whether we should post to coveralls when all parallel test finish - outputs: - COVERALLS: ${{ steps.coveralls-trigger.outputs.COVERALLS_TRIGGER }} - strategy: matrix: node-version: [10, 12, 14, 16] @@ -60,35 +51,6 @@ jobs: - name: Run Tests run: npm test - - name: Coveralls Parallel - id: coveralls-parallel - if: inputs.generate-coverage == true - continue-on-error: true - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.github_token }} - parallel: true - flag-name: run-${{ matrix.node-version }}-${{ matrix.os }} - - - name: Should Trigger coverallsapp/github-action - id: coveralls-trigger - # https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context - # when continue-on-error failed, outcome is failure and conclusion is success - if: inputs.generate-coverage == true && steps.coveralls-parallel.conclusion == 'success' && steps.coveralls-parallel.outcome != 'success' - run: | - echo "::set-output name=COVERALLS_TRIGGER::failure" - - coverage: - needs: test - runs-on: ubuntu-latest - if: inputs.generate-coverage == true && needs.test.outputs.COVERALLS != 'failure' - steps: - - name: Coveralls Finished - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - parallel-finished: true - automerge: needs: test permissions: diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml index 6bd48f8..a100630 100644 --- a/.github/workflows/plugins-ci.yml +++ b/.github/workflows/plugins-ci.yml @@ -2,20 +2,11 @@ name: Plugin CI on: workflow_call: - inputs: - generate-coverage: - description: 'Set to true to generate coverage and send to Coveralls.' - required: false - type: boolean jobs: test: runs-on: ${{ matrix.os }} - # output.COVERALLS is a variable to determine whether we should post to coveralls when all parallel test finish - outputs: - COVERALLS: ${{ steps.coveralls-trigger.outputs.COVERALLS_TRIGGER }} - strategy: matrix: node-version: [10, 12, 14, 16] @@ -35,35 +26,6 @@ jobs: - name: Run Tests run: npm test - - name: Coveralls Parallel - id: coveralls-parallel - if: inputs.generate-coverage == true - continue-on-error: true - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.github_token }} - parallel: true - flag-name: run-${{ matrix.node-version }}-${{ matrix.os }} - - - name: Should Trigger coverallsapp/github-action - id: coveralls-trigger - # https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#steps-context - # when continue-on-error failed, outcome is failure and conclusion is success - if: inputs.generate-coverage == true && steps.coveralls-parallel.conclusion == 'success' && steps.coveralls-parallel.outcome != 'success' - run: | - echo "::set-output name=COVERALLS_TRIGGER::failure" - - coverage: - needs: test - runs-on: ubuntu-latest - if: inputs.generate-coverage == true && needs.test.outputs.COVERALLS != 'failure' - steps: - - name: Coveralls Finished - uses: coverallsapp/github-action@master - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - parallel-finished: true - automerge: needs: test permissions: diff --git a/README.md b/README.md index f21f431..f640aab 100644 --- a/README.md +++ b/README.md @@ -27,19 +27,11 @@ on: jobs: call-reuseable-workflow: - uses: fastify/workflows/.github/workflows/plugins-ci.yml@v1 - with: - generate-coverage: true + uses: fastify/workflows/.github/workflows/plugins-ci.yml@v2 ``` Included in this repo is a [basic workflow](.github/workflows/plugins-ci.yml) for use across the majority of plugins, as well as variants with service containers. -## Inputs - -| Input Name | Required | Type | Default | Description | -| ------------------- | -------- | ------- | ------- | --------------------------------------------------------- | -| `generate-coverage` | false | boolean | `false` | Set to `true` to generate coverage and send to Coveralls. | - ## Acknowledgements This project is kindly sponsored by: