Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem depends on fastlane #17

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Gem depends on fastlane #17

merged 1 commit into from
Jan 23, 2018

Conversation

jmoody
Copy link
Contributor

@jmoody jmoody commented Jan 4, 2018

Motivation

This project requires fastlane.

Resolves:

KrauseFx
KrauseFx reviewed Jan 4, 2018
View reviewed changes
README.md Outdated
@@ -55,24 +55,9 @@ trainer(output_directory: ENV["CIRCLE_TEST_REPORTS"])

For more information, check out the [fastlane plugin docs](fastlane-plugin-trainer#readme).

## Without [fastlane](https://fastlane.tools)

### Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this part not any more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, there is no reason to have a Without section because there is no way to use this gem without fastlane.

It could be argued that you don't need to use this gem as fastlane plugin - the instructions that I delete would work. However, as they were written they were confusing - they implied that the gem did not need fastlane to be installed.

I can roll back that doc change if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. I think that's more for when you don't use fastlane with a Fastfile, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's more for when you don't use fastlane with a Fastfile

The implication, to me, was that fastlane was not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed doc commit.

@jmoody jmoody force-pushed the feature/gem-depends-on-fastlane branch from 84f1cba to 747a20d Compare January 8, 2018 08:42
@jmoody
Copy link
Contributor Author

jmoody commented Jan 23, 2018

Will this be merged?

@KrauseFx KrauseFx merged commit 61f1be7 into fastlane-community:master Jan 23, 2018
@KrauseFx
Copy link
Member

Thanks 👍 Should I also push a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrauseFx KrauseFx KrauseFx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoody @KrauseFx