Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak async_io test with hyper 0.14.27+ #286

Open
acfoltzer opened this issue Jul 12, 2023 · 1 comment
Open

Unbreak async_io test with hyper 0.14.27+ #286

acfoltzer opened this issue Jul 12, 2023 · 1 comment

Comments

@acfoltzer
Copy link
Contributor

As noted in #285, a change in hyper's behavior with empty chunked encoded bodies is observable via the assertions in the async_io test. We are pinning to 0.14.26 for now, but obviously would like that to be temporary.

@itsrainy
Copy link
Contributor

Even on the current hyper version this test seems to be flaky on mac, possibly also on linux. On my mac, I ran it 1000 times consecutively and it failed 6 of those times. I haven't observed it failing on my linux machine yet. Anecdotally seems to be more prone to failure in CI (I noticed it failed on #294 earlier today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants