From 61f2cf66064b2508e65139e5906abd670b771679 Mon Sep 17 00:00:00 2001 From: Integralist Date: Thu, 11 Jul 2024 16:36:45 +0100 Subject: [PATCH] fix(compute/serve): don't fail the serve workflow if github errors --- pkg/commands/compute/serve.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/commands/compute/serve.go b/pkg/commands/compute/serve.go index 9302d52b1..9c94ac049 100644 --- a/pkg/commands/compute/serve.go +++ b/pkg/commands/compute/serve.go @@ -476,6 +476,8 @@ func (c *ServeCommand) InstallViceroy( // IMPORTANT: We declare separately so to shadow `err` from parent scope. var latestVersion string + // NOTE: We won't stop the user because although we can't request the latest + // version of the tool, the user may have a local version already installed. err = spinner.Process("Checking latest Viceroy release", func(_ *text.SpinnerWrapper) error { latestVersion, err = c.ViceroyVersioner.LatestVersion() if err != nil { @@ -487,7 +489,7 @@ func (c *ServeCommand) InstallViceroy( return nil }) if err != nil { - return err + return nil // short-circuit the rest of this function } viceroyConfig := c.Globals.Config.Viceroy