From 1bbadc1615ba56a04731dafae130debb054444a7 Mon Sep 17 00:00:00 2001 From: Integralist Date: Tue, 6 Dec 2022 11:35:45 +0000 Subject: [PATCH 1/2] remove -wasm-abi which is set by default --- pkg/commands/compute/language_go.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/commands/compute/language_go.go b/pkg/commands/compute/language_go.go index 6f2c2720b..f5b6cc3d0 100644 --- a/pkg/commands/compute/language_go.go +++ b/pkg/commands/compute/language_go.go @@ -33,7 +33,7 @@ var GoConstraints = make(map[string]string) // are simply upgrading their CLI version and might not be familiar with the // changes in the 4.0.0 release with regards to how build logic has moved to the // fastly.toml manifest. -const GoDefaultBuildCommand = "tinygo build -target=wasi -wasm-abi=generic -gc=conservative -o bin/main.wasm ./" +const GoDefaultBuildCommand = "tinygo build -target=wasi -gc=conservative -o bin/main.wasm ./" // GoInstaller is the command used to install the dependencies defined within // the Go language manifest. From 5d40df77dc17c4c016dd768f65ddec87241b18e1 Mon Sep 17 00:00:00 2001 From: Integralist Date: Tue, 6 Dec 2022 11:43:10 +0000 Subject: [PATCH 2/2] update documentation for testing --- TESTING.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/TESTING.md b/TESTING.md index c92c09507..9cef18c8b 100644 --- a/TESTING.md +++ b/TESTING.md @@ -44,3 +44,11 @@ TEST_COMPUTE_BUILD_RUST=1 make test TEST_ARGS="-run TestBuildRust/fastly_crate_p When running the tests locally, if you don't have the relevant language ecosystems set-up properly then the tests will fail to run and you'll need to review the code to see what the remediation steps are, as that output doesn't get shown when running the test suite. > **NOTE**: you might notice a discrepancy between CI and your local environment which is caused by the difference in Rust toolchain versions as defined in .github/workflows/pr_test.yml which specifies the version required to be tested for in CI. Running `rustup toolchain install ` and `rustup target add wasm32-wasi --toolchain ` will resolve any failing integration tests you may be running locally. + +To the run the full test suite: + +```sh +TEST_COMPUTE_INIT=1 TEST_COMPUTE_BUILD=1 TEST_COMPUTE_DEPLOY=1 TEST_COMMAND=gotest make all +``` + +> **NOTE**: `TEST_COMMAND` is optional and allows the use of https://github.com/rakyll/gotest to improve test output.