Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of sass is breaking the build 🚨 #86

Closed
greenkeeper bot opened this issue Jul 24, 2019 · 9 comments
Closed

An in-range update of sass is breaking the build 🚨 #86

greenkeeper bot opened this issue Jul 24, 2019 · 9 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Jul 24, 2019

The dependency sass was updated from 1.22.7 to 1.22.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sass is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for Dart Sass 1.22.8

To install Dart Sass 1.22.8, download one of the packages above and add it to your PATH, or see the Sass website for full installation instructions.

Changes

JavaScript API

  • Don't crash when running in a directory whose name contains URL-sensitive characters.

  • Drop support for Node Carbon (8.x), which doesn't support url.pathToFileURL.

See the full changelog for changes in earlier releases.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jul 24, 2019

After pinning to 1.22.7 your tests are passing again. Downgrade this dependency 📌.

@FND
Copy link
Contributor

FND commented Jul 25, 2019

Drop support for Node Carbon (8.x), which doesn't support url.pathToFileURL.

https://github.com/sass/dart-sass/blob/master/CHANGELOG.md

Doesn't seem very semver; not sure what we should do about this.

@moonglum
Copy link
Member

Maintenance for Node 8 runs until the end of the year. Why does nobody care about things like that? 😭 Typical minor release change...

I guess the only option here is to make Node 10 a requirement for faucet-pipeline-sass. This is the core library, it can't be replaced... 😒

@FND
Copy link
Contributor

FND commented Jul 25, 2019

Yeah, I agree - realistically, I doubt any of our users are stuck with Node v8.

@moonglum
Copy link
Member

Agreed. But we still need to make it a... breaking change, right? So release 2.0.0?

@FND
Copy link
Contributor

FND commented Jul 25, 2019

Well, given that faucet-sass's package.json uses "sass": "~1.22.3", this is a problem for 1.x users either way, so in that regard, faucet-sass v2.0 would effectively be cosmetic?

@moonglum
Copy link
Member

True 😭 Ok. So we release a new version 1.4.0 that adjusts the travis.yml and sets

"engines": {
  "node": ">=10"
},

Right?

@FND
Copy link
Contributor

FND commented Jul 26, 2019

I suppose so, yeah.

@moonglum
Copy link
Member

This version of sass has been unpublished. The authors were not aware that this is a breaking change (:suspect:) and reverted it. Here is the explanation

Going forward, we'll avoid dropping support for Node versions that we already support as long as they're still in the long-term service window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants