-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An in-range update of sass is breaking the build 🚨 #86
Comments
After pinning to 1.22.7 your tests are passing again. Downgrade this dependency 📌. |
https://github.com/sass/dart-sass/blob/master/CHANGELOG.md Doesn't seem very semver; not sure what we should do about this. |
Maintenance for Node 8 runs until the end of the year. Why does nobody care about things like that? 😭 Typical minor release change... I guess the only option here is to make Node 10 a requirement for faucet-pipeline-sass. This is the core library, it can't be replaced... 😒 |
Yeah, I agree - realistically, I doubt any of our users are stuck with Node v8. |
Agreed. But we still need to make it a... breaking change, right? So release 2.0.0? |
Well, given that faucet-sass's |
True 😭 Ok. So we release a new version 1.4.0 that adjusts the travis.yml and sets "engines": {
"node": ">=10"
}, Right? |
I suppose so, yeah. |
This version of
|
The dependency sass was updated from
1.22.7
to1.22.8
.🚨 View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
sass is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
Status Details
Release Notes for Dart Sass 1.22.8
To install Dart Sass 1.22.8, download one of the packages above and add it to your PATH, or see the Sass website for full installation instructions.
Changes
JavaScript API
Don't crash when running in a directory whose name contains URL-sensitive characters.
Drop support for Node Carbon (8.x), which doesn't support
url.pathToFileURL
.See the full changelog for changes in earlier releases.
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
The text was updated successfully, but these errors were encountered: