From 2a728dbaa714c9cd4f24aab76111acbfae618644 Mon Sep 17 00:00:00 2001
From: David Heryanto <david.heryanto@hotmail.com>
Date: Fri, 13 Mar 2020 10:07:03 +0800
Subject: [PATCH] Add missing kafka port in example feast stream config
 Incorrectly swapped resources requests and limit

---
 infra/charts/feast/README.md                   | 6 +++---
 infra/charts/feast/README.md.gotmpl            | 6 +++---
 infra/charts/feast/values-dataflow-runner.yaml | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/infra/charts/feast/README.md b/infra/charts/feast/README.md
index 1b3f574672..3affaa2ce1 100644
--- a/infra/charts/feast/README.md
+++ b/infra/charts/feast/README.md
@@ -195,7 +195,7 @@ feast-core:
     feast:
       stream:
         options:
-          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
+          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
       jobs:
         runner: DataflowRunner
         options:
@@ -355,9 +355,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
 feast-online-serving:
   javaOpts: "-Xms2048m -Xmx2048m"
   resources:
-    requests:
-      memory: "4096Mi"
     limits:
+      memory: "4096Mi"
+    requests:
       memory: "2048Mi"
       cpu: "2"
 ```
diff --git a/infra/charts/feast/README.md.gotmpl b/infra/charts/feast/README.md.gotmpl
index 269b051700..83e009418c 100644
--- a/infra/charts/feast/README.md.gotmpl
+++ b/infra/charts/feast/README.md.gotmpl
@@ -182,7 +182,7 @@ feast-core:
     feast:
       stream:
         options:
-          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
+          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
       jobs:
         runner: DataflowRunner
         options:
@@ -342,9 +342,9 @@ to set the minimum and maximum heap. This is an example reasonable value to set
 feast-online-serving:
   javaOpts: "-Xms2048m -Xmx2048m"
   resources:
-    requests:
-      memory: "4096Mi"
     limits:
+      memory: "4096Mi"
+    requests:
       memory: "2048Mi"
       cpu: "2"
 ```
diff --git a/infra/charts/feast/values-dataflow-runner.yaml b/infra/charts/feast/values-dataflow-runner.yaml
index a0cb477c6f..3cdf5cc78e 100644
--- a/infra/charts/feast/values-dataflow-runner.yaml
+++ b/infra/charts/feast/values-dataflow-runner.yaml
@@ -5,7 +5,7 @@ feast-core:
     feast:
       stream:
         options:
-          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1>
+          bootstrapServers: <kafka_sevice_load_balancer_ip_address_1:31090>
       jobs:
         runner: DataflowRunner
         options: