diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 398efc3a99..e8d00798c0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,9 +2,10 @@ 1. Ensure that your code follows our code conventions: https://github.com/feast-dev/feast/blob/master/CONTRIBUTING.md#code-style--linting 2. Run unit tests and ensure that they are passing: https://github.com/feast-dev/feast/blob/master/CONTRIBUTING.md#unit-tests -3. If your change introduces any API changes, make sure to update the integration tests scripts here: https://github.com/feast-dev/feast/tree/master/sdk/python/tests or https://github.com/feast-dev/feast/tree/master/sdk/go +3. If your change introduces any API changes, make sure to update the integration tests here: https://github.com/feast-dev/feast/tree/master/sdk/python/tests 4. Make sure documentation is updated for your PR! -5. Make sure you have signed the CLA https://cla.developers.google.com/clas +5. Make sure your commits are signed: https://github.com/feast-dev/feast/blob/master/CONTRIBUTING.md#signing-off-commits +6. Make sure your PR title follows conventional commits (e.g. fix: [description] vs feat: [description]) --> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cf89007520..ea1dd8ad13 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,6 +8,16 @@ the main Feast repository: - [Feast Java Serving](#feast-java-serving) - [Feast Go Client](#feast-go-client) +## Community +See [Contribution process](https://docs.feast.dev/project/contributing) and [Community](https://docs.feast.dev/community) for details on how to get more involved in the community. + +A quick few highlights: +- [RFCs](https://drive.google.com/drive/u/0/folders/0AAe8j7ZK3sxSUk9PVA) +- [Community Slack](https://slack.feast.dev/) +- [Feast Dev Mailing List](https://groups.google.com/g/feast-dev) +- [Community Calendar](https://calendar.google.com/calendar/u/0?cid=ZTFsZHVhdGM3MDU3YTJucTBwMzNqNW5rajBAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ) + - Includes biweekly community calls at 10AM PST + ## Making a pull request ### Pull request checklist diff --git a/docs/community.md b/docs/community.md index 53e00eb4eb..c0ead3dda1 100644 --- a/docs/community.md +++ b/docs/community.md @@ -10,6 +10,8 @@ * [Mailing list](https://groups.google.com/d/forum/feast-dev): We have both a user and developer mailing list. * Feast users should join [feast-discuss@googlegroups.com](mailto:feast-discuss@googlegroups.com) group by clicking [here](https://groups.google.com/g/feast-discuss). * Feast developers should join [feast-dev@googlegroups.com](mailto:feast-dev@googlegroups.com) group by clicking [here](https://groups.google.com/d/forum/feast-dev). + * People interested in the Feast community newsletter should join feast-announce by clicking [here](https://groups.google.com/d/forum/feast-announce). +* [Community Calendar](https://calendar.google.com/calendar/u/0?cid=ZTFsZHVhdGM3MDU3YTJucTBwMzNqNW5rajBAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ): Includes community calls and design meetings. * [Google Folder](https://drive.google.com/drive/u/0/folders/1jgMHOPDT2DvBlJeO9LCM79DP4lm4eOrR): This folder is used as a central repository for all Feast resources. For example: * Design proposals in the form of Request for Comments (RFC). * User surveys and meeting minutes. @@ -31,12 +33,11 @@ We have a user and contributor community call every two weeks (Asia & US friendl Please join the above Feast user groups in order to see calendar invites to the community calls {% endhint %} -### Frequency (alternating times every 2 weeks) +### Frequency (every 2 weeks) -* Tuesday 18:00 pm to 18:30 pm (US, Asia) -* Tuesday 10:00 am to 10:30 am (US, Europe) +* Tuesday 10:00 am to 10:30 am PST ### Links * Zoom: [https://zoom.us/j/6325193230](https://zoom.us/j/6325193230) -* Meeting notes: [https://bit.ly/feast-notes](https://bit.ly/feast-notes) +* Meeting notes (incl recordings): [https://bit.ly/feast-notes](https://bit.ly/feast-notes) diff --git a/docs/project/contributing.md b/docs/project/contributing.md index ac1ab480a0..933237f204 100644 --- a/docs/project/contributing.md +++ b/docs/project/contributing.md @@ -4,11 +4,8 @@ We use [RFCs](https://en.wikipedia.org/wiki/Request_for_Comments) and [GitHub is We follow a process of [lazy consensus](http://community.apache.org/committers/lazyConsensus.html). If you believe you know what the project needs then just start development. If you are unsure about which direction to take with development then please communicate your ideas through a GitHub issue or through our [Slack Channel](../community.md) before starting development. -Please [submit a PR ](https://github.com/feast-dev/feast/pulls)to the master branch of the Feast repository once you are ready to submit your contribution. Code submission to Feast \(including submission from project maintainers\) require review and approval from maintainers or code owners. +Please [submit a PR](https://github.com/feast-dev/feast/pulls) to the master branch of the Feast repository once you are ready to submit your contribution. Code submission to Feast \(including submission from project maintainers\) require review and approval from maintainers or code owners. PRs that are submitted by the general public need to be identified as `ok-to-test`. Once enabled, [Prow](https://github.com/kubernetes/test-infra/tree/master/prow) will run a range of tests to verify the submission, after which community members will help to review the pull request. -{% hint style="success" %} -Please sign the [Google CLA](https://cla.developers.google.com/) in order to have your code merged into the Feast repository. -{% endhint %} - +See also [Community](../community.md) for other ways to get involved with the community (e.g. joining community calls) \ No newline at end of file