Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-demand feature view couldn't be renamed #2064

Closed
pyalex opened this issue Nov 18, 2021 · 2 comments
Closed

On-demand feature view couldn't be renamed #2064

pyalex opened this issue Nov 18, 2021 · 2 comments
Assignees

Comments

@pyalex
Copy link
Collaborator

pyalex commented Nov 18, 2021

Expected Behavior

After renaming function that is wrapped into @on_demand_feature_view decorator and running feast apply changes are being applied.

Current Behavior

On feast apply exception is thrown

feast.errors.FeatureViewNotFoundException: Feature view <previous view name> does not exist in project <project name>

Traceback

  File "/Users/pyalex/projects/feast/sdk/python/feast/repo_operations.py", line 193, in apply_total
    store.apply(
  File "/Users/pyalex/projects/feast/sdk/python/feast/feature_store.py", line 542, in apply
    self._registry.delete_feature_view(
  File "/Users/pyalex/projects/feast/sdk/python/feast/registry.py", line 630, in delete_feature_view
    raise FeatureViewNotFoundException(name, project)

Steps to reproduce

  1. create odfv
  2. feast apply
  3. rename odfv
  4. feast apply

Specifications

  • Version: master
  • Platform:
  • Subsystem:

Possible Solution

@pyalex
Copy link
Collaborator Author

pyalex commented Nov 18, 2021

UPD. Couldn't be just deleted either

@felixwang9817
Copy link
Collaborator

Interesting, I believe #2054 should have fixed this. Were you up to date with #2054 when you saw this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants