Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint issues on master #2249

Closed
felixwang9817 opened this issue Jan 27, 2022 · 1 comment
Closed

Lint issues on master #2249

felixwang9817 opened this issue Jan 27, 2022 · 1 comment

Comments

@felixwang9817
Copy link
Collaborator

felixwang9817 commented Jan 27, 2022

Expected Behavior

make lint-python should work on master

Current Behavior

make lint-python yields the following error:

feast/feature_store.py:1440: error: Name 'FieldStatus.ValueType' is not defined
feast/feature_store.py:1493: error: Name 'FieldStatus.ValueType' is not defined

I suspect this issue was introduced by #2223, and is occurring due to some packages being out of date (most likely mypy-protobuf or something related). In particular, this kind of typing is described here, so it should be correct.

A probably related issue is that CI_REQUIRED contains mypy-protobuf==3.1.0 but DEV_REQUIRED contains mypy-protobuf==1.*.

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

@judahrand
Copy link
Member

That dev requirement does look like the issue! Apologies for that an oversight on my behalf. So many places to update dependencies!

@adchia adchia closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants