fix: Method _should_use_plan only returns true for local sqlite provider

[nossrannug]

Only the SQLite local provider supports _plan and _apply_diffs. Updated
the _should_use_plan method to only return true for that setup so that other local providers don't need to implement these methods right now.

Signed-off-by: Gunnar Sv Sigurbjörnsson gunnar.sigurbjornsson@gmail.com

What this PR does / why we need it:
Only the SQLite provider supports _plan and _apply_diffs today. Before this can be added to other providers there needs to be some discussion around the InfraObject and how the update and teardown is performed.

My main worry at the moment is that the InfraObject can be constructed from a proto and then the update method can be called. This requires all the connection information and credentials to be present in the infra object proto.

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #2344 (33a858f) into master (57d1343) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
+ Coverage   86.39%   86.41%   +0.02%     
==========================================
  Files         116      116              
  Lines        9670     9698      +28     
==========================================
+ Hits         8354     8381      +27     
- Misses       1316     1317       +1     

Flag	Coverage Δ
integrationtests	75.36% <0.00%> (-0.14%)	⬇️
unittests	58.29% <0.00%> (-0.14%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	91.88% <0.00%> (ø)
.../integration/online_store/test_universal_online.py	96.67% <0.00%> (-0.51%)	⬇️
sdk/python/feast/infra/online_stores/dynamodb.py	86.23% <0.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py	94.93% <0.00%> (+0.09%)	⬆️
sdk/python/feast/infra/online_stores/datastore.py	90.52% <0.00%> (+0.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d1343...33a858f. Read the comment docs.

[felixwang9817]

/lgtm

[felixwang9817]

@nossrannug oops missed a small bug: looks like you need to do a null check on online_store here:

self.config.online_store.type == "sqlite"

integration tests are failing

separately, we recently moved to semantic release, so all PR titles now need to prefixed with e.g. "refactor" or "fix" depending on the type of PR - you can see some other PRs for an example, and the set of possible prefixes is documented here

[nossrannug]

@nossrannug oops missed a small bug: looks like you need to do a null check on online_store here:

self.config.online_store.type == "sqlite"

integration tests are failing

separately, we recently moved to semantic release, so all PR titles now need to prefixed with e.g. "refactor" or "fix" depending on the type of PR - you can see some other PRs for an example, and the set of possible prefixes is documented here

Thanks @felixwang9817, I'm sorry I missed that. I've added the null check and updated the title.

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, nossrannug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[woop]

🎉 This PR is included in version 0.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀