Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_proto_json.py broken by new python/google/protobuf/json_format.py changes #2634

Closed
michaelcui1986 opened this issue May 3, 2022 · 1 comment

Comments

@michaelcui1986
Copy link

Expected Behavior

test_proto_json.py passes

Current Behavior

test_proto_json.py not passes

Steps to reproduce

make test-python

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

The cause is a new version of json_format.py from protobuf repo. Broken by protocolbuffers/protobuf@ab4585a, this added addition "path" parameter in the customized function defined in proto_json.py

@achals
Copy link
Member

achals commented May 4, 2022

cc @tsotnet

Thanks for the report @michaelcui1986 ! I think we saw this when protobuf was upgraded unintentionally which broke stuff. That's why we decided to pin protobuf in #2480 to <3.20.

@kevjumba kevjumba closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants