Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyspark dependency breaks Snowflake offline store #3383

Closed
beauchbum opened this issue Dec 8, 2022 · 3 comments · Fixed by #3388 or #3397
Closed

pyspark dependency breaks Snowflake offline store #3383

beauchbum opened this issue Dec 8, 2022 · 3 comments · Fixed by #3388 or #3397

Comments

@beauchbum
Copy link
Contributor

beauchbum commented Dec 8, 2022

This commit introduced a pyspark dependency for the Snowflake offline store that is not reflected in setup.py. This causes feast actions to fail due to:

File "/usr/local/lib/python3.9/site-packages/feast/infra/offline_stores/snowflake.py", line 26, in <module>
  from pyspark.sql import DataFrame, SparkSession
ModuleNotFoundError: No module named 'pyspark'`.

Steps to reproduce

  • Install feast = {extras = ["snowflake"], version = "^0.27.0"}
  • Set up a Feature Repository with a Snowflake offline store
  • Run feast plan

Specifications

  • Version: 0.27.0
  • Platform:
  • Subsystem:

Possible Solution

Not sure - would prefer not needing pyspark for Snowflake offline store to work, but if that's the case then add to setup.py?

@beauchbum beauchbum changed the title Pyspark dependency breaks Snowflake offline store pyspark dependency breaks Snowflake offline store Dec 8, 2022
@achals
Copy link
Member

achals commented Dec 8, 2022

cc @adchia @sfc-gh-madkins - should this dep on pyspark be optional (by moving the import inside the to_spark_df method, or should it be added as a proper dep to the snowflake extra?

@adchia
Copy link
Collaborator

adchia commented Dec 8, 2022

yeah should be a try import probably

@beauchbum
Copy link
Contributor Author

beauchbum commented Dec 12, 2022

@adchia Thanks for weighing in on this. Any ideas on when this might be worked on (and eventually released)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment