Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to query created or event_timestamp fields from feature views #3412

Closed
franciscojavierarceo opened this issue Dec 23, 2022 · 1 comment
Labels
kind/bug priority/p2 wontfix This will not be worked on

Comments

@franciscojavierarceo
Copy link
Member

franciscojavierarceo commented Dec 23, 2022

Expected Behavior

get_historical_features should be able to return the created date or event_timestamp if explicitly requested, currently this just breaks.

features = store.get_historical_features(
        entity_df=entity_df,
        features=[
            "driver_hourly_stats:acc_rate",
            "driver_hourly_stats:conv_rate",
            "driver_hourly_stats:avg_daily_trips",
            "driver_hourly_stats:created",
            "driver_hourly_stats:event_timestamp",
        ]
    )

Current Behavior

get_historical_features should be able to return the created date if explicitly requested, currently this just breaks.

Steps to reproduce

import pandas as pd
from datetime import datetime, timedelta
from feast import FeatureStore

store = FeatureStore(".")


def main():
    entity_df = pd.DataFrame.from_dict({
        "driver_id": [1001, 1002],
        "event_timestamp": [datetime.utcnow() - timedelta(days=2), datetime.utcnow() - timedelta(days=2)],
        "input_value": [100, 200],
    })

    features = store.get_historical_features(
        entity_df=entity_df,
        features=[
            "driver_hourly_stats:acc_rate",
            "driver_hourly_stats:conv_rate",
            "driver_hourly_stats:avg_daily_trips",
            "driver_hourly_stats:created",
            "driver_hourly_stats:event_timestamp",
        ]
    )
    print('here are the features!\n', features.to_df())

if __name__ == '__main__':
    main()

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

#3411

@franciscojavierarceo franciscojavierarceo changed the title Unable to query created field from feature views Unable to query created or event_timestamp fields from feature views Dec 27, 2022
@stale
Copy link

stale bot commented May 20, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/p2 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant