Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_online_features method in OnlineStore interface #4270

Closed
tokoko opened this issue Jun 12, 2024 · 1 comment · Fixed by #4319
Closed

Add get_online_features method in OnlineStore interface #4270

tokoko opened this issue Jun 12, 2024 · 1 comment · Fixed by #4319

Comments

@tokoko
Copy link
Collaborator

tokoko commented Jun 12, 2024

I'm proposing we refactor online feature retrieval to move most of the logic for get_online_features and get_online_features_async methods from FeatureStore class in feature_store.py to new methods in OnlineStore class that will have default implementations. This shouldn't be breaking change, nor impact performance in any way, but offers a number of advantages.

  • This more closely follows the structure of OfflineStore class that has get_historical_features as one of it's methods.
  • Simplifies the implementation of remote online store as all request info will be exposed to OnlineStore provider. Feature Services are really tricky to implement now.
  • Related to the point above, simplifies security checks in remote servers as more of request context is available to be passed to the server.
  • Will be a step in a direction to address long-standing issue with our online stores that require us making a single round-trip to the database for each feature view because only a single feature view at a time is exposed to online store provider.
@tokoko
Copy link
Collaborator Author

tokoko commented Jun 12, 2024

@tokoko tokoko changed the title Add get_online_features metho in OnlineStore inferface Add get_online_features method in OnlineStore inferface Jun 12, 2024
@tokoko tokoko changed the title Add get_online_features method in OnlineStore inferface Add get_online_features method in OnlineStore interface Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant