Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy argtype failure in ui_server.py with mypy>=1.11 #4462

Closed
cburroughs opened this issue Aug 29, 2024 · 0 comments · Fixed by #4500
Closed

mypy argtype failure in ui_server.py with mypy>=1.11 #4462

cburroughs opened this issue Aug 29, 2024 · 0 comments · Fixed by #4500

Comments

@cburroughs
Copy link
Contributor

Expected Behavior

Type checking should pass!

Current Behavior

With mypy 1.11

feast/ui_server.py:54: error: Argument 1 to "files" has incompatible type "str | None"; expected "str | Module"  [arg-type]
feast/ui_server.py:54: note: Error code "arg-type" not covered by "type: ignore" comment

Steps to reproduce

  • Get your dev environment to the point where you can run make lint-python
  • pip install --upgrade 'mypy>=1.11'
  • make lint-python` --> the above error

Specifications

  • Version: main

Possible Solution

Presumably mypy has identified a nullness bug, or a bug in itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant