Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy arg-type failure in postgres/connection_utils.py with psycopg>=3.2 #4463

Closed
cburroughs opened this issue Aug 29, 2024 · 0 comments · Fixed by #4498
Closed

mypy arg-type failure in postgres/connection_utils.py with psycopg>=3.2 #4463

cburroughs opened this issue Aug 29, 2024 · 0 comments · Fixed by #4498

Comments

@cburroughs
Copy link
Contributor

Expected Behavior

Type checking should pass

Current Behavior

With psycopg>=3.2,

feast/infra/utils/postgres/connection_utils.py:66: error: Argument 2 to "make_conninfo" has incompatible type "**dict[str, object]"; expected "str | int | None"  [arg-type]

Steps to reproduce

  • Get your dev environment to the point where you can run make lint-python
  • pip install --upgrade 'psycopg>=3.2'
  • make lint-python` --> the above error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants