Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftovers of PR #4771 #4793

Closed
dmartinol opened this issue Nov 26, 2024 · 0 comments · Fixed by #4809 or #4811
Closed

Leftovers of PR #4771 #4793

dmartinol opened this issue Nov 26, 2024 · 0 comments · Fixed by #4809 or #4811
Labels
kind/feature New feature or request

Comments

@dmartinol
Copy link
Contributor

This issue is defined to track the leftovers of #4771 that must be closed before the next release:

  • infra/feast-operator/config/samples/v1alpha1_featurestore_db_persistence.yaml: add sample secret link
  • Can you add simple tests for invalid store type for each of the feast service? link
  • Test overriding secret keys link
  • Fix examples in the decription (wrong usage of secretKeyName)
  • Use required fields in CRD type link, other
  • Describe CRD types link
  • Unit test incorrect types link

@tmihalac @tchughesiv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dmartinol