From 5f85bb248e39292cf6e8f9eb9b0a9e6f948ea722 Mon Sep 17 00:00:00 2001 From: Jose Pinero Date: Sun, 28 Mar 2021 13:20:20 +0200 Subject: [PATCH 1/3] Update some outdated terraform files --- .../google-cloud-gke-with-terraform.md | 13 +++++++++++-- infra/terraform/gcp/feast.tf | 4 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md b/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md index a3252cf0bb..003fcacaf8 100644 --- a/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md +++ b/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md @@ -22,7 +22,16 @@ This Terraform configuration creates the following resources: * Install [Helm](https://helm.sh/docs/intro/install/) \(tested with v3.3.4\) * GCP [authentication](https://cloud.google.com/docs/authentication) and sufficient [privilege](https://cloud.google.com/iam/docs/understanding-roles) to create the resources listed above. -### 2. Configure Terraform +### 2. Configure Feast Helm Repository + +Add Feast Helm repository so Charts can be found by executing: + +```bash +$ helm repo add feast-charts https://feast-helm-charts.storage.googleapis.com +$ helm repo update +``` + +### 3. Configure Terraform Create a `.tfvars` file under`feast/infra/terraform/gcp`. Name the file. In our example, we use `my_feast.tfvars`. You can see the full list of configuration variables in `variables.tf`. Sample configurations are provided below: @@ -38,7 +47,7 @@ dataproc_staging_bucket = "feast-dataproc" ``` {% endcode %} -### 3. Apply +### 4. Apply After completing the configuration, initialize Terraform and apply: diff --git a/infra/terraform/gcp/feast.tf b/infra/terraform/gcp/feast.tf index e528cd15ee..e781602c2a 100644 --- a/infra/terraform/gcp/feast.tf +++ b/infra/terraform/gcp/feast.tf @@ -36,7 +36,7 @@ locals { } } - feast-online-serving = { + feast-serving = { enabled = true "application-override.yaml" = { feast = { @@ -113,7 +113,7 @@ resource "helm_release" "feast" { depends_on = [kubernetes_secret.feast-postgres-secret, kubernetes_secret.feast_sa_secret] name = var.name_prefix - chart = "../../charts/feast" + chart = "feast-charts/feast" values = [ yamlencode(local.feast_helm_values) From 4068ca630a00d28e7ed00929623313917e85a0dc Mon Sep 17 00:00:00 2001 From: Jose Pinero Date: Tue, 30 Mar 2021 23:08:47 +0200 Subject: [PATCH 2/3] Rollback docs and update feast chart location --- infra/terraform/gcp/feast.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/infra/terraform/gcp/feast.tf b/infra/terraform/gcp/feast.tf index e781602c2a..f5e26bb113 100644 --- a/infra/terraform/gcp/feast.tf +++ b/infra/terraform/gcp/feast.tf @@ -113,7 +113,7 @@ resource "helm_release" "feast" { depends_on = [kubernetes_secret.feast-postgres-secret, kubernetes_secret.feast_sa_secret] name = var.name_prefix - chart = "feast-charts/feast" + chart = "https://feast-helm-charts.storage.googleapis.com/feast-0.100.4.tgz" values = [ yamlencode(local.feast_helm_values) From 79f402e79824bcf8c30ccbea4a5c094a219ef972 Mon Sep 17 00:00:00 2001 From: Jose Pinero Date: Tue, 30 Mar 2021 23:09:09 +0200 Subject: [PATCH 3/3] Rollback docs --- .../google-cloud-gke-with-terraform.md | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md b/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md index 003fcacaf8..a3252cf0bb 100644 --- a/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md +++ b/docs/getting-started/install-feast/google-cloud-gke-with-terraform.md @@ -22,16 +22,7 @@ This Terraform configuration creates the following resources: * Install [Helm](https://helm.sh/docs/intro/install/) \(tested with v3.3.4\) * GCP [authentication](https://cloud.google.com/docs/authentication) and sufficient [privilege](https://cloud.google.com/iam/docs/understanding-roles) to create the resources listed above. -### 2. Configure Feast Helm Repository - -Add Feast Helm repository so Charts can be found by executing: - -```bash -$ helm repo add feast-charts https://feast-helm-charts.storage.googleapis.com -$ helm repo update -``` - -### 3. Configure Terraform +### 2. Configure Terraform Create a `.tfvars` file under`feast/infra/terraform/gcp`. Name the file. In our example, we use `my_feast.tfvars`. You can see the full list of configuration variables in `variables.tf`. Sample configurations are provided below: @@ -47,7 +38,7 @@ dataproc_staging_bucket = "feast-dataproc" ``` {% endcode %} -### 4. Apply +### 3. Apply After completing the configuration, initialize Terraform and apply: