From a2f0e7a6ee75df4da0f70f0012cc02e0d6f5ed7c Mon Sep 17 00:00:00 2001 From: zhilingc Date: Wed, 8 Jan 2020 10:46:46 +0800 Subject: [PATCH 1/3] Add PR template --- .github/pull_request_template.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..bb6b2489dd --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,28 @@ + + +**What this PR does / why we need it**: + +**Which issue(s) this PR fixes**: + +Fixes # + +**Does this PR introduce a user-facing change?**: + +```release-note + +``` From 99f764020c192b6b623d28a5820e7d8f55572216 Mon Sep 17 00:00:00 2001 From: zhilingc Date: Wed, 8 Jan 2020 13:25:54 +0800 Subject: [PATCH 2/3] Remove line about not using fixes --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index bb6b2489dd..ac1d1e8a10 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,7 +13,6 @@ Fixes # From b4fd4c7855d9fa76135431e00acf3b460d5a7871 Mon Sep 17 00:00:00 2001 From: zhilingc Date: Wed, 8 Jan 2020 14:43:27 +0800 Subject: [PATCH 3/3] Add notes about CLA and release notes --- .github/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac1d1e8a10..b9c8cd6dff 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,6 +4,7 @@ 2. Run unit tests and ensure that they are passing: https://github.com/gojek/feast/blob/master/docs/contributing.md#running-unit-tests 3. If your change introduces any API changes, make sure to update the integration tests scripts here: https://github.com/gojek/feast/tree/master/tests/e2e 4. Make sure documentation is updated for your PR! +5. Make sure you have signed the CLA https://cla.developers.google.com/clas --> @@ -21,6 +22,9 @@ Fixes # If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". + +For more information about release notes, see kubernetes' guide here: +http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note