Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Discussion about security #7

Open
eddyystop opened this issue Jun 24, 2017 · 2 comments
Open

Discussion about security #7

eddyystop opened this issue Jun 24, 2017 · 2 comments
Labels

Comments

@eddyystop
Copy link
Member

The server needs to approve the publication requested by the client. The docs talk about additional service filters doing this, however they don't have much info available.

@marshall is likely the go-to person for this.

Idea #1:

// In addition to
serverPublications(app, commonPublications, ['messages', 'channels']);
// allow the signature
serverPublications(app, commonPublications, { messages: fcn1, channels: fcn2 });

The fcn* would be called when a publication is requested by the client. Its param would be derived from the options object in

clientPublications.addPublication(feathersClient, 'messages', {
  module: commonPublications,
  name: 'query',
  params: { username },
});

Any additional props in there would also be passed to fcn*

@marshall
Copy link

@eddyystop just a friendly reminder to be more careful when tagging, because you've pinged the wrong Marshall again -- this is becoming a bit of a pattern, i've been put on 5 different issues already this year within feathersjs.

please try to be more careful when using @, I have enough notification backlog from github as is, without getting more from a project I don't contribute to and have no involvement with :)

@eddyystop
Copy link
Member Author

Sorry, his Slack name is marshall.
@marshallswain

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants