Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk: Medium] package.json - Denial of Service (due 11/16/20) #4043

Closed
3 tasks
Tracked by #137
hcaofec opened this issue Sep 16, 2020 · 4 comments
Closed
3 tasks
Tracked by #137

[Snyk: Medium] package.json - Denial of Service (due 11/16/20) #4043

hcaofec opened this issue Sep 16, 2020 · 4 comments
Assignees
Labels
Security: moderate Remediate within 60 days
Milestone

Comments

@hcaofec
Copy link
Contributor

hcaofec commented Sep 16, 2020

Denial of Service:

Vulnerable module: node-fetch
Introduced through: draft-js@0.10.5
Exploit maturity: No known exploit
Fixed in: 2.6.1, 3.0.0-beta.9

Detailed paths
Introduced through: fec-cms@1.0.0 › draft-js@0.10.5 › fbjs@0.8.17 › isomorphic-fetch@2.2.1 › node-fetch@1.7.3
Remediation: Upgrade node-fetch to version 2.6.1, 3.0.0-beta.9 or higher.

Overview
node-fetch is an A light-weight module that brings window.fetch to node.js

Affected versions of this package are vulnerable to Denial of Service. Node Fetch did not honor the size option after following a redirect, which means that when a content size was over the limit, a FetchError would never get thrown and the process would end without failure.

https://app.snyk.io/vuln/SNYK-JS-NODEFETCH-674311

Action items

  • identify priority/categorizing and document. Notify concerned parties.

Completion criteria:

  • Verify that this is a problem and address the vulnerability appropriately
  • see if this fix also solves the vulnerability from Update ua-parser-js@0.7.22 #4087 by removing ua-parser-js from package.json. If so, we can keep it removed from package.json.
@jason-upchurch
Copy link
Contributor

There is a live discussion in draftail repo about draft-js dependency. (Remediating through the current method: Upgrade draft-js@0.10.5 to draft-js@0.11.7 results in unmet dependencies.)
springload/draftail#213 (comment)

@rfultz
Copy link
Contributor

rfultz commented Nov 3, 2020

We've moved this to Blocked because there's no remediation for the affected package's dependency grandparent (if that's a thing. The package that requires the package that requires the affected package) and that package hasn't seen any development in over a year.

The vulnerability is only Medium and isn't publicly exposed for us until a user logs in to the admin section.

@jason-upchurch
Copy link
Contributor

@rfultz @patphongs I moved this to blocked 13.8. Please let me know if it should be moved elsewhere.

@lbeaufort
Copy link
Member

Because the vulnerability can't be exploited except for authenticated user, this is not a meaningful vulnerability. This is also no longer being flagged by Snyk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security: moderate Remediate within 60 days
Projects
None yet
Development

No branches or pull requests

5 participants