Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: Passive listeners and scrolling performance #4176

Closed
rfultz opened this issue Nov 5, 2020 · 0 comments · Fixed by #4504
Closed

Optimization: Passive listeners and scrolling performance #4176

rfultz opened this issue Nov 5, 2020 · 0 comments · Fixed by #4504

Comments

@rfultz
Copy link
Contributor

rfultz commented Nov 5, 2020

Background

Looking to optimize the site's performance and that of the homepage specifically, the Lighthouse tool in Chromium browsers has made some suggestions. Some of these will have repercussions throughout the app so we're going to make them their own tickets.

Recommendation: Does not use passive listeners to improve scrolling performance

Consider marking your touch and wheel event listeners as passive to improve your page's scroll performance. details

Overview

We could add , {passive: true} to the scroll listeners.

Benefit (the 80 of 80/20)

It's recommended but not sure know who might notice

Effort (the 20 of 80/20)

Minimal

Complications

  • Being that these are third-party code (e.g. recaptcha), we may not be able to do this (like if the listeners are automatic and the code doesn't give us an option for passive)
  • Would just need to check that recaptcha and other scroll-listeners still work

Related tickets

This was referenced Nov 5, 2020
@rfultz rfultz self-assigned this Mar 4, 2021
@rfultz rfultz modified the milestones: Sprint 14.1, Sprint 14.2 Mar 5, 2021
@rfultz rfultz modified the milestones: Sprint 14.2, Sprint 14.3 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant