Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk: HIGH] Underscore Arbitrary Code Execution (due 4/30/21) #4523

Closed
2 tasks
johnnyporkchops opened this issue Mar 30, 2021 · 2 comments · Fixed by #4535
Closed
2 tasks

[Snyk: HIGH] Underscore Arbitrary Code Execution (due 4/30/21) #4523

johnnyporkchops opened this issue Mar 30, 2021 · 2 comments · Fixed by #4535
Assignees
Labels
High priority HOTFIX Merge with git flow Security: high Remediate within 30 days Work: Front-end
Milestone

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Mar 30, 2021

Summary

Underscore Arbitrary Code Execution

Detailed paths
Introduced through: fec-cms@1.0.0 › underscore@1.9.1
Remediation: Upgrade to underscore@1.12.1
Introduced through: fec-cms@1.0.0 › glossary-panel@1.0.0 › underscore@1.9.1
Remediation: No remediation path available.
Overview
underscore is a JavaScript's functional programming helper library.

Affected versions of this package are vulnerable to Arbitrary Code Execution via the template function, particularly when a variable property is passed as an argument as it is not sanitized.

Completion criteria

  • Determine how we're affected by this
  • Decide whether we tag this to come back when there's a remediation path, OR refactor all of our codebase to remove underscore (and/or lodash)
@patphongs
Copy link
Member

This upgrade broke our filings datatables on the canonical candidate and committee profile pages. Need to revisit to see how to upgrade and patch this later.

@rfultz
Copy link
Contributor

rfultz commented Apr 29, 2021

Closing this because its tickets have been merged

@rfultz rfultz closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority HOTFIX Merge with git flow Security: high Remediate within 30 days Work: Front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants