Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass Upgrade - Stylelint #5680

Closed
6 tasks
Tracked by #137
rfultz opened this issue Mar 30, 2023 · 1 comment
Closed
6 tasks
Tracked by #137

Sass Upgrade - Stylelint #5680

rfultz opened this issue Mar 30, 2023 · 1 comment
Assignees

Comments

@rfultz
Copy link
Contributor

rfultz commented Mar 30, 2023

Summary

Let's get back to linting & checking our scss formatting.

We currently aren't doing either.

Notes/considerations

Prettier is awfully opinionated—enough that we've intentionally removed it.

Stylelint has excellent support and we can use the same configuration with npm, CLI, and IDE.

Completion criteria

  • A scss linter and format checker/reporter has been added to our workflow.
  • The team has decided and implemented some rules
  • npm scripts include command(s) to lint / format and auto-fix our scss files
  • IDEs (at least VS Code; Sublime would be nice) are using the linting and formatting rules defined in the repo
  • Tech-debt ticket(s) created to follow up and scoot us toward supporting rules we're currently skipping
  • Ticket created to include scss linter/formatter in build scripts -OR- that work is included here
@rfultz
Copy link
Contributor Author

rfultz commented Aug 4, 2024

Closing this and moving the updated work to #6387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants