-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name to ofec_pacronyms #4210
Comments
@PaulClark2 should the designation be PRINCIPAL CAMPAIGN COMMITTEE? |
@fecjjeng here's my insert statement - my only fuzzy bit is how to generate the
|
@lbeaufort The "index" column of this particular table is manually created. |
@lbeaufort @fecjjeng should we be more encompassing? When we add committees to pacronyms does is change how the search rank orders them? These candidate committees with financial activity do not contain the candidate's last name. The query below is for 1979 through 2024. If we are adding more, we could limit it to 2019 through 2024.
|
@lbeaufort the second to last line of your insert script should be |
@PaulClark2 I’m fine being more encompassing. Results are ordered by financial activity, so additions won’t change sort order except inserting more values. |
@lbeaufort thanks. Let's insert them all from 1979 through 2024. |
@lbeaufort you might want to refine my script. I noticed two examples where it incorrectly includes a committee even though the last name is part of the committee name. It might also be just as quick to scan the list instead of refining the script. There are only 800-or-so of these. cc: @fecjjeng P00014357 BUCHSER-LOCHOCKI, SUSAN C00728014 FRIENDS OF SUSAN BUCHSER LOCHOCKI FOR PRESIDENT OF THE USA H8AL02130 BRIGHT SR, BOBBY NEAL C00446138 BRIGHT FOR CONGRESS |
@lbeaufort the following row had been inserted into DEV. Please review it and let me know if we want to insert into STG and PRD. |
@fecjjeng @PaulClark2 I confirmed on Dev after a MV refresh that Amy for America now appears in the committee search when you type “Klobuchar” |
@PaulClark2 @lbeaufort do you want to keep this ticket open to add more names? |
@fecjjeng I'm sorry I missed your comment. I plan to review @PaulClark2's query and make an updated insert statement today. |
I've been translating this into Postgresql but it's been taking a really long time to run, so it's been hard to get the commented out line to work. Here's what I have so far. I'll probably switch to running this on the stage database and try to figure out why it's taking so long.
|
@lbeaufort Are you still improvising the SQL or need help with anything? could you provide an update on this issue? |
Here's the query, in psql:
@fecjjeng @PaulClark2 it looks good to me - do you want to go forward with adding these to the |
@PaulClark2 @lbeaufort |
I'm comfortable with adding these 1487 rows to pacronyms. |
INSERT INTO ofec_pacronyms /* |
@PaulClark2 @lbeaufort The above sql statements had been executed in PRD/STG/DEV database. |
What we are after:
We would like users to find candidates by their commonly know name.
Task
Add Klobuchar as a pacronym of Amy for America
pacronym: KLOBUCHAR
id number: C00696419
full name: AMY FOR AMERICA
city: MINNEAPOLIS
state: MN
connected organization or sponsor name: [NULL]
designation: PRINCIPAL CAMPAIGN COMMITTEE
committee type: PRESIDENTIAL
Completion criteria
The text was updated successfully, but these errors were encountered: