Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Contribute to Microsoft.SemanticKernel.Connectors.Onnx? #4

Open
stephentoub opened this issue Jun 3, 2024 · 3 comments
Open

Contribute to Microsoft.SemanticKernel.Connectors.Onnx? #4

stephentoub opened this issue Jun 3, 2024 · 3 comments

Comments

@stephentoub
Copy link

stephentoub commented Jun 3, 2024

Nice job with the library. I've had it on my todo list to augment the https://www.nuget.org/packages/Microsoft.SemanticKernel.Connectors.Onnx library with the ONNX runtime GenAI support, sat down to implement it, and stumbled across your implementation. I can still do so, but would you instead just like to contribute your implementation there in order to centralize our efforts?

cc: @matthewbolanos, @markwallace-microsoft

@feiyun0112
Copy link
Owner

feiyun0112 commented Jun 4, 2024

Nice job with the library. I've had it on my todo list to augment the https://www.nuget.org/packages/Microsoft.SemanticKernel.Connectors.Onnx library with the ONNX runtime GenAI support, sat down to implement it, and stumbled across your implementation. I can still do so, but would you instead just like to contribute your implementation there in order to centralize our efforts?

cc: @matthewbolanos, @markwallace-microsoft

@stephentoub I have pull codes to microsoft/semantic-kernel#6518

@elbruno
Copy link

elbruno commented Jun 10, 2024

This is so cool!

I added support to Vision scenarios (while writing samples for Phi-3 https://github.com/elbruno/phi3-labs/tree/main/src/SemanticKernel.Connectors.OnnxRuntimeGenAI)

Do you want me to create a PR and you can have them here? or should we wait for the SK merge?

Best

PS: your library is so cool!

@feiyun0112
Copy link
Owner

This is so cool!

I added support to Vision scenarios (while writing samples for Phi-3 https://github.com/elbruno/phi3-labs/tree/main/src/SemanticKernel.Connectors.OnnxRuntimeGenAI)

Do you want me to create a PR and you can have them here? or should we wait for the SK merge?

Best

PS: your library is so cool!

you can contribute to SK, this project will be frozen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants