feat: allow to publish to Open VSX only #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `OVSX_PAT` is set but `VSCE_PAT` is missing, pushing the VSIX to the Open VSX Registry is still possible. Closes #483 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
felipecrs
requested changes
Jul 11, 2023
felipecrs
changed the title
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Great review. Thank you! Here, I have changed one of the error codes to align with the other ones. Let me know if you want it back. |
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
felipecrs
approved these changes
Jul 11, 2023
|
Thanks a lot for the PR. I took the liberty of making some changes, hope you don't mind. :) |
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
BTW I'm happy to explain the changes I made if you'd like to know why I did them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
OVSX_PATis set butVSCE_PATis missing, pushing the VSIX to the Open VSX Registry is still possible.Closes #483