Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Remove bullMQ deps #174

Closed
felixmosh opened this issue Nov 26, 2020 · 0 comments · Fixed by #177
Closed

Task: Remove bullMQ deps #174

felixmosh opened this issue Nov 26, 2020 · 0 comments · Fixed by #177

Comments

@felixmosh
Copy link
Owner

Currently there are 2 check which are specific to bullMQ

  1. https://github.com/vcapretz/bull-board/blob/master/src/index.ts#L43
  2. https://github.com/vcapretz/bull-board/blob/master/src/routes/cleanAll.ts#L28

This usages are require us to put bullMQ in our deps even though it is not required.

My suggestion is to provide 2 wrappers one for each Q, which provides the same API.
setQueues will accept them.
Innerly each wrapper will make the "unique" calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant