Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared peer dependency between @bull-board/api and @bull-board/ui breaks with yarn's PnP system #564

Closed
JasonMan34 opened this issue Apr 30, 2023 · 0 comments · Fixed by #565

Comments

@JasonMan34
Copy link
Contributor

Yarn's PnP system considers accessing the @bull-board/ui package without listing it as a dependency dangerous, so it fails to run (repro here)

This causes the @bull-board/express package to break when using yarn with PnP:

Error: @bull-board/api tried to access @bull-board/ui, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @bull-board/ui (via "@bull-board/ui/package.json")
Required by: @bull-board/api@npm:5.1.1 (via /Users/user/repos/bull-board-yarn-dep-bug/.yarn/cache/@bull-board-api-npm-5.1.1-533fa06b5d-b4570ef330.zip/node_modules/@bull-board/api/dist/src/)

Listing @bull-board/ui is a peer dependency or @bull-board/api should resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant