Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose "Traditional Chinese", but it shows "Simplified Chinese" #716

Closed
andyliangtw opened this issue Apr 12, 2020 · 16 comments
Closed

Choose "Traditional Chinese", but it shows "Simplified Chinese" #716

andyliangtw opened this issue Apr 12, 2020 · 16 comments
Milestone

Comments

@andyliangtw
Copy link

As the title.

image

@felixse
Copy link
Owner

felixse commented Apr 13, 2020

are only some of them simplified or all? And if you select simplified Chinese do you see the correct translations?

@andyliangtw
Copy link
Author

My Win10 system uses Traditional Chinese.

"System Default" shows all Simplified Chinese, which is the same when I select "Simplified Chinese".

"Traditional Chinese" shows Simplified Chinese as well. The little difference is there would be English in some part. (like the img below)
image

Hope this problem can be fixed asap. Thanks!

@felixse
Copy link
Owner

felixse commented Apr 14, 2020

Ok, so the English text is because translations were missing when this was released. And the settings menu item on this screenshot has the same signs in both simplified and traditional Chinese. Don't know if this is correct though. Maybe have a look at the translations here and check for those occurrences of simplified Chinese when traditional is selected

@andyliangtw
Copy link
Author

I've checked the translations. It seems OK for Traditional Chinese.
The part of translation (where the terminal shows Simplified Chinese) is OK though.
Maybe the code connected to the wrong translation?

Thanks for replying.
and I'll use some free time to help translation to make the terminal perfect haha

@felixse
Copy link
Owner

felixse commented Apr 14, 2020

OK, maybe this has improved since the last released. Current master looks like this:

zh-Hant:
image

zh-Hans:
image

@andyliangtw
Copy link
Author

I'm sorry to say that there's still something wrong.

First,
Traditional Chinese = 繁體中文 = zh-hant ('t' for 'traditional')
Simplified Chinese = 简体中文 = zh-hans ('s' for 'simplified')
Thus, the two images above have to be exchanged.

Second, only the red rectangle parts are Traditional Chinese, which means there's almost Simplified Chinese.
79253758-09000300-7e84-11ea-90fe-bb88fa86c27e
79253796-16b58880-7e84-11ea-91d1-80ae3abe5ba1

In the translation page, there are 3 Chineses. "Chinese (TW)" is the only Traditional Chinese.
image

@felixse
Copy link
Owner

felixse commented Apr 14, 2020

ok, so apparently this got mixed up:
image

Chinese (TW) is currently not used since it's not translated enough.
Also the on/off labels for switches are translated by the system.

So it would be correct if I swap those two and we ignore the on/off labels? The remaining issues seem to be in the translations on POEditor if I understand correctly

@andyliangtw
Copy link
Author

Yeah, I believe that's the problem, and the swap can solve it (on/off label can be shown correctly as well).
I've almost completed the translation. Its completion rate is 87% now (may be higher tomorrow). So, I believe that's a good choice to use it.

@andyliangtw
Copy link
Author

andyliangtw commented Apr 15, 2020

I've completed the Traditional Chinese translation (100%). Thanks.

@felixse
Copy link
Owner

felixse commented Apr 15, 2020

So this is a third translation now, zh-TW (臺灣華語)?

@felixse felixse added this to the 0.7.1.0 milestone Apr 15, 2020
@andyliangtw
Copy link
Author

andyliangtw commented Apr 16, 2020

Not actually.
Traditional Chinese is used by Taiwan, Hong Kong, Macao, etc. Taiwan is just one of them.
Thus, I think 2 translations of Chinese is enough.

  1. zh-hant (繁體中文) use "Chinese (TW)"
  2. zh-hans (简体中文) use "Chinese" or "Chinese (simplified)" (no big difference, both are Simplified Chinese)

Thanks for fixing this!

@felixse
Copy link
Owner

felixse commented Apr 18, 2020

OK, great. Thank you for looking into this. Regarding Chinese and Chinese (simplified) on POEditor: I think we should delete one of them to avoid confusion. Which would you recommend keeping?

@andyliangtw
Copy link
Author

I think "Chinese (simplified)" is better because its name is more clear about the type. ( It seems no difference in the content.)
BTW, I discovered the name and icon of "Chinese (TW)" is changed in POEditor. The new name is reasonable, but the icon is not suitable because China don't use Traditional Chinese. Thus, I think the previous icon is better.

@felixse
Copy link
Owner

felixse commented Apr 20, 2020

OK, reverted to Chinese (TW) and deleted one of the simplified Chinese. This will be included in update in a few days

@felixse felixse closed this as completed Apr 20, 2020
@mrchar
Copy link

mrchar commented May 18, 2020

hello, is there any new progress? and how soon will it be released?

@felixse
Copy link
Owner

felixse commented May 18, 2020

There are some packaging issues which are being looked at right now, but I cannot give you any ETA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants