Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSet with no datapoints crash #58

Closed
g-bauer opened this issue Sep 29, 2022 · 0 comments · Fixed by #124
Closed

DataSet with no datapoints crash #58

g-bauer opened this issue Sep 29, 2022 · 0 comments · Fixed by #124
Labels
bug Something isn't working
Milestone

Comments

@g-bauer
Copy link
Contributor

g-bauer commented Sep 29, 2022

Currently, the unit of the predicted property is "inferred" by taking the unit of the 0'th element of the target vector. This panics if the vector is empty. See here.

In predict, instead of allocating an array and iterating over the index, we can use iter().map().collect().

@g-bauer g-bauer added the bug Something isn't working label Sep 29, 2022
@prehner prehner added this to the v0.4.0 milestone Dec 29, 2022
@prehner prehner modified the milestones: v0.4.0, v0.5.0 Jan 27, 2023
@g-bauer g-bauer modified the milestones: v0.5.0, v0.4.0 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants