Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious warning "skipping duplicate package spinhelloworld" when using Rust SDK #793

Closed
itowlson opened this issue Sep 27, 2022 · 3 comments · Fixed by #862
Closed

Spurious warning "skipping duplicate package spinhelloworld" when using Rust SDK #793

itowlson opened this issue Sep 27, 2022 · 3 comments · Fixed by #862
Assignees
@dicej

Comments

@itowlson
Copy link
Contributor

When you build Rust application that references the Rust SDK, you get a spurious warning:

warning: skipping duplicate package `spinhelloworld` found at `/home/ivan/.cargo/git/checkouts/spin-91500438ac5656d2/b316f47/examples/http-rust`

Looking at the directory, it seems Cargo checks out out the entire Spin repo into the Cargo cache. So I think the issue is that the repo contains several projects called spinhelloworld, and Cargo is looking at all of them as well as the SDK crate itself?

I don't think we used to see this, and I now see it on SDK revs going right back to 0.1.0, so I wonder if this is a new warning added to a recent version of Rust?
@itowlson
Copy link
Contributor Author

Warning doesn't happen in Rust 1.62.1 but does in 1.63.0.

@itowlson
Copy link
Contributor Author

itowlson commented Oct 2, 2022

Also affects programs that import Spin crates, it seems.

@itowlson
Copy link
Contributor Author

itowlson commented Oct 3, 2022

rust-lang/cargo#10752

@kate-goldenring kate-goldenring moved this to 🆕 Triage Needed in Spin Triage Oct 3, 2022
@kate-goldenring kate-goldenring moved this from 🆕 Triage Needed to 🏗 In progress in Spin Triage Oct 10, 2022
@dicej dicej mentioned this issue Oct 26, 2022
Merged
Repository owner moved this from 🏗 In progress to ✅ Done in Spin Triage Oct 27, 2022
@itowlson itowlson mentioned this issue Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dicej dicej

Labels
None yet
Projects
Spin Triage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename example and test crates to avoid cargo warnings dicej/spin
2 participants
@itowlson @dicej