node ids should always be a string or a buffer

webtorrent · Jan 2, 2016 · 6c7da04 · 6c7da04
1 parent 644b18d
commit 6c7da04
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/client.js b/client.js
@@ -647,6 +647,7 @@ DHT.prototype._addNode = function (addr, nodeId, from) {
   if (self.destroyed) return
 
   var nodeIdBuffer = idToBuffer(nodeId)
+  if (!nodeIdBuffer) return
   nodeId = idToHexString(nodeId)
 
   if (nodeIdBuffer.length !== 20) {
@@ -1681,8 +1682,10 @@ function transactionIdToBuffer (transactionId) {
 function idToBuffer (id) {
   if (Buffer.isBuffer(id)) {
     return id
-  } else {
+  } else if (typeof id === 'string') {
     return new Buffer(id, 'hex')
+  } else {
+    return null
   }
 }