Exclude types before generating them #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
May 18, 2022
sszgen/testcases/case1_encoding.go
Outdated
| { | ||
| elemIndx := hh.Index() | ||
| byteLen := uint64(len(c.Bar)) | ||
| if byteLen > 2048 { |
There was a problem hiding this comment.
Yes, you are right. This is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the
include-objsflag which forcessszgento only generate objects that are included, theexclude-objsflag performs that filter after the generation is done. Thus, if an invalid object is present on the file, it cannot be excluded and the generation fails like in #75. An example of an invalid type would be:Since we cannot add tags to this
aliasstruct. This type could never be rendered.I am still not sure if we should be smart and skip right away these objects from the generation. Then, for now, this is a good enough workaround to remove this limitation.
It also fixes the core issue on #75 in which the tags used to declare one
aliaswould be used in another one.