Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise dialogue timeout handling #413

Open
Dacksus opened this issue Jun 11, 2024 · 0 comments
Open

Revise dialogue timeout handling #413

Dacksus opened this issue Jun 11, 2024 · 0 comments
Assignees
Labels
c-bug Category: Something isn't working p-high Priority: High priority task

Comments

@Dacksus
Copy link
Contributor

Dacksus commented Jun 11, 2024

To allow dialogues being picked up again even after agent restart, dialogue history is persisted in a json file, which needs to be removed at some point. Since proper conclusion of a dialogue can't be guaranteed, there currently is a local timeout, after which a dialogue is removed. There are several potential issues with that that need to be addressed:

  • the timeout is currently not synced, i.e., both parties could have different timeouts without knowing why the other party is not responding anymore (after their local timeout expired)
  • the timeout is not considered anywhere in the dialogue engine (e.g., asserting that it is not expired before sending another message), it would only inherently lead to failure as one side won't be able to recognize the session anymore
@Archento Archento added c-bug Category: Something isn't working p-high Priority: High priority task labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-bug Category: Something isn't working p-high Priority: High priority task
Projects
None yet
Development

No branches or pull requests

2 participants