Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

版本升级到0.2.4之后，解析D3包出问题 #32

Open
y8n opened this issue May 29, 2019 · 2 comments
Open

版本升级到0.2.4之后，解析D3包出问题 #32

y8n opened this issue May 29, 2019 · 2 comments

Comments

@y8n
Copy link

y8n commented May 29, 2019 •
edited
Loading

fis3-hook-amd 包从v0.2.2升级到 v0.2.4的时候，发现引入D3库的项目打包会有问题。

排查的结果是 commit#bf7bbeaa12 中 L101 的正则匹配问题，将D3中如下正常代码匹配成了注释，继而导致parse编译失败

PS. d3版本为v4.13.0

image
y8n referenced this issue May 29, 2019
@2betop
修复 fis command 标记依赖丢失的问题
bf7bbea
@2betop
Copy link
Contributor

2betop commented Jun 3, 2019

image
不对吧，应该会被match 成 字符串的

@y8n
Copy link
Author

y8n commented Jun 11, 2019

@2betop 可以看下这个例子，我用0.2.4中新增的匹配正则的代码对D3 v4.13.0 内容做匹配，最后的结果是有部分代码当成注释被截断了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2betop @y8n