Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff cannot be applied #105

Closed
rzhornyk opened this issue Dec 1, 2020 · 2 comments
Closed

Diff cannot be applied #105

rzhornyk opened this issue Dec 1, 2020 · 2 comments

Comments

@rzhornyk
Copy link

rzhornyk commented Dec 1, 2020

Hi @johanneswilm

I found case similar to #90 and #97 but with difference that diff cannot be applied.
See JS fiddle with code to reproduce https://jsfiddle.net/0hg5xkpn/31/

There a lot of repeating diffs (3962) and after some iteration it tries to remove option as text element, but condition in applyDiff method not allow to do that

if (!node || node.nodeType !== 3) {
return false

As a result entire apply stops and HTML changes became partially applied.

Could you take a look?

@johanneswilm
Copy link
Member

thanks @rzhornyk ! This has been fixed in 4.2.2.

@rzhornyk
Copy link
Author

rzhornyk commented Dec 2, 2020

Cool!
@johanneswilm thank you for quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants