Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MaxWidth enum to Width #14817

Open
zepfietje opened this issue Nov 16, 2024 · 0 comments
Open

Rename MaxWidth enum to Width #14817

zepfietje opened this issue Nov 16, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@zepfietje
Copy link
Member

zepfietje commented Nov 16, 2024

I think we initially used MaxWidth because it matches the sizing scale of Tailwind's max width utility class. However, the other day they copied that over to the width utility too. Not all APIs in Filament that accept the MaxWidth enum actually concern the max width, rather the fixed with of an element. Therefore I suggest we rename the MaxWidth enum to Width in v4.

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants