Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-icons does not work with markdown-preview #435

Closed
Ben3eeE opened this issue Oct 13, 2016 · 0 comments
Closed

File-icons does not work with markdown-preview #435

Ben3eeE opened this issue Oct 13, 2016 · 0 comments
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.

Comments

@Ben3eeE
Copy link

Ben3eeE commented Oct 13, 2016

The file-icons package does not work correctly with markdown-preview.

Reproduction Steps:

  1. Open Atom in the atom/tabs package repository.
  2. Ensure you have the Show Icons setting in the tabs package set to true.
  3. Open README.md
  4. Open markdown-preview with Ctrl-Shift-M

Expected behavior:

markdown-preview tab to have the icon from the file-icons package.

Observed behavior:

markdown-preview has the icon from the Show Icons setting.
mdp atom icon

Now reload Atom Ctrl-Alt-R

Expected behavior:

markdown-preview tab to have the same icon and nothing to change.

Observed behavior:

markdown-preview incorrectly aligned other icon. This does not happen without the file-icons package installed.
mdp icon after reload

Atom version: 1.12.0-beta1
OS and version: Windows 7

Installed packages:

file-icons I disabled all other packages.

Additional information:

  • Problem can be reproduced in safe mode: No
  • Problem started happening recently, didn't happen in an older version of Atom: Dont know
  • Problem can be reliably reproduced, doesn't happen randomly: Yes
  • Problem happens with all files and projects, not only some files or projects: Only with markdown files, but with all markdown files.
@Alhadis Alhadis added the bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. label Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.
Projects
None yet
Development

No branches or pull requests

2 participants