Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack files not proper icons #748

Closed
hyperupcall opened this issue Jul 13, 2018 · 2 comments
Closed

Webpack files not proper icons #748

hyperupcall opened this issue Jul 13, 2018 · 2 comments
Labels
enhancement Feature requests or suggested improvements. filetype-support New file-extensions or filename patterns associated with an existing icon.

Comments

@hyperupcall
Copy link

Replacing webpack.config.js with webpack.common.js, webpack.dev.js, and webpack.prod.js (as per https://webpack.js.org/guides/production/) yielded an unexpected result.

Neither webpack.common.js, webpack.dev.js, nor the webpack.prod.js file had the proper Webpack file icon (which was associated with webpack.config.js).

Could the scope of the Webpack icon be changed to add these specific file names? I tried to add them manually, but avoided this as I did not want my changes to be overridden by an update.

@Alhadis
Copy link
Member

Alhadis commented Jul 14, 2018

Ugh, you're right. Currently, it's expecting conf or config to be part of the filename. 😞

Would the following pattern work?

match: ///
	(^|\.)    # Start of file, or something following a dot (such as "dev.webpack.js")
	webpack
	(file)?   # For "webpackfile.js"
	(?=\.)    # Followed by a dot
	.*        # Stuff like ".config" or ".development" or ".production.config", etc
	\.
	(js|jsx|ts|tsx|json)
	$
///i

This matches any filename that starts with webpack. and ends in a supported file extension: js, jsx, ts, tsx, or json.

@Alhadis
Copy link
Member

Alhadis commented Jul 15, 2018

Never mind. I realised it was silly to be cautious when Webpack can't stop changing its APIs anyway... 😀

@Alhadis Alhadis added enhancement Feature requests or suggested improvements. filetype-support New file-extensions or filename patterns associated with an existing icon. labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or suggested improvements. filetype-support New file-extensions or filename patterns associated with an existing icon.
Projects
None yet
Development

No branches or pull requests

2 participants