Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a start-epoch-diff option #1224

Closed
6 of 11 tasks
anjor opened this issue Feb 27, 2023 · 2 comments
Closed
6 of 11 tasks

Add a start-epoch-diff option #1224

anjor opened this issue Feb 27, 2023 · 2 comments
Labels

Comments

@anjor
Copy link
Contributor

anjor commented Feb 27, 2023

Checklist

  • This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
  • This is not a new feature or enhancement request. If it is, please open a new idea discussion instead. New feature and enhancement requests would be entertained by the boost team after a thorough discussion only.
  • I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to boost.

Boost component

  • boost daemon - storage providers
  • boost client
  • boost UI
  • boost data-transfer
  • boost index-provider
  • Other

Boost Version

v1.5.2

Describe the Bug

Today if a client wants to specify a longer duration for the SPs, the client is required to figure out the current head and add the number of epochs they want. This requires an extra call from the client either to a lotus node or a boost node.

Instead, the client should be able to provide a start-epoch-diff which specifies the amount of time starting from the current head that the client is ok with waiting before the deal is published on chain.

Other considerations:

  • This needs to be a separate flag instead of reworking start-epoch for backwards compatibility
  • start-epoch should supersede this setting, again for backwards compatibility.

Logging Information

n/a

Repo Steps

  1. Run '...'
  2. Do '...'
  3. See error '...'
    ...
@anjor
Copy link
Contributor Author

anjor commented Feb 27, 2023

@nonsense
Copy link
Member

Added start-epoch-head-offset flag. Thanks @anjor

@github-project-automation github-project-automation bot moved this to Done in Boost Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants